Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/blowfish #405

Merged
merged 5 commits into from
Oct 4, 2023
Merged

Feature/blowfish #405

merged 5 commits into from
Oct 4, 2023

Conversation

Kalkwst
Copy link
Contributor

@Kalkwst Kalkwst commented Oct 4, 2023 •
edited
Loading

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Comments in areas I changed are up to date
  • I have added comments to hard-to-understand areas of my code
  • I have made corresponding changes to the README.md

@Kalkwst Kalkwst requested a review from siriak as a code owner October 4, 2023 18:04
@codecov
Copy link

codecov bot commented Oct 4, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2d6a3ee) 95.79% compared to head (2ffe59c) 95.90%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
+ Coverage   95.79%   95.90%   +0.11%     
==========================================
  Files         220      221       +1     
  Lines        8957     9200     +243     
==========================================
+ Hits         8580     8823     +243     
  Misses        377      377
Files Coverage Δ
Algorithms/Encoders/BlowfishEncoder.cs 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

siriak
siriak approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak
Copy link
Member

siriak commented Oct 4, 2023

Please fix these issues
image

siriak
siriak requested changes Oct 4, 2023
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy fails

@Kalkwst Kalkwst requested a review from siriak October 4, 2023 18:36
@Kalkwst
Copy link
Contributor Author

Kalkwst commented Oct 4, 2023

Codacy fails

Fixed :)

@siriak siriak merged commit 5d9c5fe into TheAlgorithms:master Oct 4, 2023
4 checks passed
@Kalkwst Kalkwst deleted the feature/Blowfish branch October 4, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kalkwst @siriak