Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update CMake version #1271 #1284

Merged

Conversation

rbevin777
Copy link
Contributor

Description of Change

This change is an update to use the latest version of CMake.

References

#1271

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

Copy link
Member

@madhavgaba madhavgaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 3.22 newer than 3.6? Am i missing something?

@rbevin777
Copy link
Contributor Author

Is 3.22 newer than 3.6? Am i missing something?

Yea they are using semantic versioning as far as I'm aware

@rbevin777
Copy link
Contributor Author

Is there anything more I need to do with this PR or do i just wait for reviews and approvals?

@Panquesito7 Panquesito7 added the enhancement New feature or request label Jul 19, 2023
@Panquesito7 Panquesito7 linked an issue Jul 19, 2023 that may be closed by this pull request
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thank you! 🚀
Would you like to do the same in the C++ repository (TheAlgorithms/C-Plus-Plus#2479)?

@Panquesito7 Panquesito7 merged commit 1bbbac6 into TheAlgorithms:master Jul 19, 2023
@rbevin777
Copy link
Contributor Author

Awesome. Thank you! 🚀 Would you like to do the same in the C++ repository (TheAlgorithms/C-Plus-Plus#2479)?

Yea can do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Update CMake to a newer version
4 participants