Fix sort testcase input sorted unintentionally #256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A slice is a references to its underlying array. If a slice is passed as an argument and modified in a function, the original slice is also modified. As getSortedVersion and other sorting functions modify a given slice, testcase inputs are unintentionally sorted beforehand. To avoid that, passes a cloned slices to these functions.
tjgurwara99
approved these changes
Feb 23, 2021
This timeout is caused by fixing an issue that slices of testcases were unintentionally being sorted. If array is sorted, the complexities of bubble sort and insertion sort are O(n), but in general they are O(n^2) and 500k is large enough to cause timeout.
vzvu3k6k
force-pushed
the
fix-sort-tests
branch
from
125e574
to
0bbc1db
Compare
|
@tjgurwara99 Now that |
tjgurwara99
requested changes
Feb 27, 2021
Co-authored-by: Taj <tjgurwara99@users.noreply.github.com>
|
This issue has been resolved recently when I was restructuring the repo - I completely forgot that there was a PR open on that exact same issue of test cases being sorted resulting in false passes. If I remembered I would have merged your PR but since this has been resolved, I am closing this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
getSortedVersionand other sorting functions modify a given slice, testcase inputs are unintentionally sorted beforehand.To avoid that, passes a cloned slices to these functions.