refactor heapsort to support generic #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phantomnat
requested review from
siriak,
raklaptudirm,
tjgurwara99 and
yanglbme
as code owners
|
You've broken another implementation. Please fix that. |
|
Thank you for the suggestion. I brought back the heap code. |
Then this PR is not solving the Issue that it claims to solve. If you added the old implementation back, you also need to add the old tests back. Making this a separate implementation of HeapSort with little benefit. |
|
I refactored it to shared the implementation of Hopefully, this will make the heap more generic |
tjgurwara99
reviewed
Oct 10, 2022
tjgurwara99
approved these changes
Oct 15, 2022
raklaptudirm
approved these changes
Oct 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #419
Details: