Skip to content

Conversation

ephraimduncan
Copy link
Contributor

@ephraimduncan ephraimduncan commented Oct 5, 2020

Welcome to JavaScript community

Describe your change:

  • Add tests
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ephraimduncan ephraimduncan changed the title Dephraiim Add tests to Math Oct 5, 2020
@ephraimduncan ephraimduncan marked this pull request as ready for review October 6, 2020 11:29
@ephraimduncan
Copy link
Contributor Author

@itsvinayak

@itsvinayak itsvinayak merged commit e112434 into TheAlgorithms:master Oct 11, 2020
@ephraimduncan ephraimduncan deleted the dephraiim branch October 15, 2020 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants