Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show AppImageLauncher settings in XFCE #329

Merged
merged 1 commit into from
May 10, 2020
Merged

Show AppImageLauncher settings in XFCE #329

merged 1 commit into from
May 10, 2020

Conversation

koyuawsmbrtn
Copy link
Contributor

This makes the AppImageLauncher settings show up in the XFCE control panel

@TheAssassin
Copy link
Owner

Now I'm curious? What version of XFCE are you using? I use the one on xubuntu 18.04 (up to date), and I can see the settings in the control panel.

I'm not opposed to adding more categories, but I'll have to check their meaning.

@TheAssassin
Copy link
Owner

DesktopSettings;LXQt; looks unrelated, what's their purpose?

@koyuawsmbrtn
Copy link
Contributor Author

koyuawsmbrtn commented May 10, 2020 •
edited
Loading

DesktopSettings;LXQt; looks unrelated, what's their purpose?

LXQT also offers to have .desktop files in the control panel and DesktopSettings is here for compatibilty reasons. I just merely copy and pasted the categories found from the Kvantum settings item.

Now I'm curious? What version of XFCE are you using? I use the one on xubuntu 18.04 (up to date), and I can see the settings in the control panel.

I'm not opposed to adding more categories, but I'll have to check their meaning.

It doesn't work for me and I'm running Xubuntu 18.04 as well. This patch makes it work though.

@TheAssassin
Copy link
Owner

I'm not opposed at all to merging this, the opposite is true. Thanks for helping out!

But I would like to understand the different behavior. Have you checked your "Other" area? For me, it looks like this:

screenshot_2020-05-10_20-40-52

We anyway have some time until the CI is satisfied (which it will be, of course).

@koyuawsmbrtn
Copy link
Contributor Author

Funnily enough this resides in my "Personal" section of the control panel

image

@TheAssassin
Copy link
Owner

Yeah, probably now after these changes. Anyway, there is no reason not to do so, so let's just merge them. Thanks!

@TheAssassin TheAssassin merged commit ba27455 into TheAssassin:master May 10, 2020
@TheAssassin
Copy link
Owner

Funnily enough this resides in my "Personal" section of the control panel

I mean, that comes from that X-XFCE-PersonalSettings obviously...

@tsujan tsujan mentioned this pull request Jun 25, 2022
Closed
@stefonarch stefonarch mentioned this pull request Jun 29, 2022
Merged
TheAssassin pushed a commit that referenced this pull request Jun 29, 2022
@stefonarch @TheAssassin
Update appimagelaunchersettings.desktop
56797ad 
Under LXQt it is show in the LXQt section, while it should be shown under "other" as it's not a DE setting.
lxqt/lxqt-config#868 (comment)
#329 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koyuawsmbrtn @TheAssassin