Fix the bug in issue#120 "NameError: name 'metadata' is not defined" #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove multiprocessing to fix the bug in issue TheBrownLab#120 "metadata not defined in forest_local.py"(and import PyQt5 for ete3, I'm not sure if it's necessary.).
Only fix the bug in issue TheBrownLab#120.
To fix the snakemake bug "MissingRuleException:
No rule to produce snakemake (if you use input functions make sure that they don't raise unexpected exceptions)."
It's caused by "--of phylip" because in original code, one of output file "matrix.fas" in python didn't match the name "f'{out_dir}/matrix.{out_dict[out_format.lower()]}'"(if use default --of fasta, they are thesame) in snakemake file.
robert-ervin-jones
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply remove the multiprocessing module and use "for loop" to receive data in suspicious trees.
This is usable but may slow down the process in handling big data.
It will be better if someone fix the bug inside the multiprocessing module, which caused the NameError in suspicious_clades.
I fix it this way just because I'm not familiar to multiprocessing.