This repository has been archived by the owner on Aug 9, 2021. It is now read-only.
Allow filter by recording type in search recording screen #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've squeezed in the recordingType select box as a b-form-select component. I also turned the tagType into b-form-select, rather than multiselect which took up too much space (and wasn't needed as only ever selecting one option)
arthurmcgregor
changed the title
mjs
reviewed
Sep 25, 2018
There was a problem hiding this comment.
Looks great. Three things:
- The query criteria form layout is a little off now. The Device field no longer aligns with the Duration field underneath. Looking at the Search button, it looks like Duration is actually the one that's wrong.
- Could your previously selected Recording Type preference be remembered? Grant was keen on this.
- If "Audio" or "Video and Audio" is selected can Tag Types and Animals be disabled (and their values ignored). Those don't currently make sense for audio recordings.
I'm happy for 2 and 3 to be done as separate PRs if you prefer.
|
The duration field was always slightly out - even before I added the recording type input! But fixed now. Perhaps merge this PR as is and add 2 and 3 to the backlog... |
|
Thanks for fixing. Would you mind adding issues for 2 and 3? |
mjs
approved these changes
Sep 25, 2018
This was referenced Sep 25, 2018
|
Issues for 2 and 3 created and added to v1 milestone |
|
Thanks @arthurmcgregor |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18
Should be merged after #61 because I didn't manage my branches too well in my fork sorry! It's really only the last commit that is different here.