Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion seems to increase the size of embedded cover art. #24

Closed
whi-tw opened this issue Feb 5, 2021 · 5 comments
Closed

Conversion seems to increase the size of embedded cover art. #24

whi-tw opened this issue Feb 5, 2021 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@whi-tw
Copy link

whi-tw commented Feb 5, 2021

I've seen some inflation of file sizes during the conversion process. This appears to be because jpgs are being converted to pngs.

when converting manually, I add -c:v copy to the ffmpeg commandline, which just copies the jpg over. Searching around to find some kind of reference, this appears to be the solution used here: https://superuser.com/a/1605308

@whi-tw
Copy link
Author

whi-tw commented Feb 5, 2021

some data:

exiftool Lorde/Pure\ Heroine/08\ -\ Still\ Sane.flac | grep Picture
Picture                         : (Binary data 729115 bytes, use -b option to extract)
exiftool Lorde/Pure\ Heroine/08\ -\ Still\ Sane.mp3 | grep Picture
Picture                         : (Binary data 3725056 bytes, use -b option to extract)

@TheCaptain989
Copy link
Owner

Holy ballooning cover art, Batman! I never noticed this. 🤨
Let me verify this and I'll get back with you.

@TheCaptain989 TheCaptain989 self-assigned this Feb 6, 2021
@TheCaptain989
Copy link
Owner

I have verified this behavior and am implementing the suggested fix. I'll be publishing an update soon with your other Issue #25 and issue #23

@TheCaptain989 TheCaptain989 added the bug Something isn't working label Mar 6, 2021
TheCaptain989 added a commit that referenced this issue Mar 6, 2021
Resolves issue #23, #24, and #25.
@whi-tw
Copy link
Author

whi-tw commented Mar 6, 2021

Amazing! Thanks! I'll take a look in the morning!

@TheCaptain989
Copy link
Owner

Resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants