Evaluate accuracy

[cbachhuber]

Addressing #23: First version of accuracy evaluation. The evaluator assigns clusters to the closest ground truth vehicles. For the overall summary, it does not yet distinguish vehicles. For simplicity, it lumps the errors from all vehicles into shared cumulative variables.

[TheCodez]

Awesome work as always 👍
A few changes and this is ready to go.

[TheCodez]

Can you merge my pull request to make the dbscan api more appealing
cbachhuber#1

[cbachhuber]

Good points, thanks for those improvements! Merged.

[TheCodez]

You can add the std::optional changes to this pr as well if you want.

[cbachhuber]

Thanks, done :)

[TheCodez]

I checked this out and sadly Visual Studio has no <experimental/optional> for C++ 14. Optional is only available starting at version 17.

[cbachhuber]

... and I expected that for once, we would not have issues with MSVC 😅

Which version of Visual studio are you using? Could it be an older one that does not yet support std::experimental for C++14?

If we cannot solve this through Visual studio, I see a couple of options here:

• Use boost's optional. Optional was first proposed in boost. However, this would introduce an additional dependency for this project
• Implement our own optional (it's a really simple class)/copypaste from e.g. here
• Import the above repo as git submodule
• Do not use optional (least favorable for imho)

All this aside: in general, I suggest removing optional from this PR. Let's deal with it separately, this PR is already huge 😄

[TheCodez]

I would remove optional from this pr.
Given there’s need to use optional every in the codebase and the small use case here, I see no reason to add another dependency.

This could change of course at some point.

[TheCodez]

I tested with Visual Studio 2019 and the error persists. If there are more cases where optional could be used I would go with option 2 or 3.

[cbachhuber]

Thanks for checking. I removed optional, should be ready to merge now.

If I find time, I'll introduce optional to this repo. But first, I think I want to tidy up in folder dogm/demo ;)