Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coordinate transforms #47

Merged
merged 13 commits into from
May 1, 2020

Conversation

cbachhuber
Copy link
Contributor

@cbachhuber cbachhuber commented May 1, 2020

Continuing #23: Replaced all unknown transforms from the simulation and evaluation chain except angle regression by well-understood transforms.

  • Fix coordinate transforms in simulator and precision evaluator.
    • In the measurement grid, vehicles are now at the coordinates defined in their constructor. Examples: Vehicle at position (10,20) will be at pixels (10/resolution, 20/resolution). A vehicle with position (grid_size, grid_size) will be at the top right of the grid.
    • Same for velocity: I verified that e.g. a vehicle with a speed of 10m/s covers 10/resolution pixels in one second.
    • Both simulator and evaluator now take grid size, grid resolution, number of scan points, and sensor FoV into account. They work for arbitrary values (within a sensible range 😉 ) in these four variables.
  • Vehicle positions now denote their center. Makes precision evaluation simpler
  • In code, I noted that laser.max_range must be grid_size, otherwise vehicle positions are incorrect. Same for resolutions.
  • Removed visual clutter from demo output

I think this is a substantial improvement for simulation and evaluation. Now we understand them almost entirely.

@cbachhuber cbachhuber changed the title Linear coordinate transform Fix coordinate transforms May 1, 2020
@TheCodez
Copy link
Owner

TheCodez commented May 1, 2020

Thank you 👍 Cool to see improvements here!

In code, I noted that laser.max_range must be grid_size, otherwise vehicle positions are incorrect. Same for resolutions.

I just pushed a commit to fix this, but I want to further change this (the line above my change).
Currently the ego vehicle is at the bottom of the map. In the future I want to move the vehicle to the center of the map as in the paper (in the paper the images are actually cropped so it looks like our current implementation with the vehicle in the bottom).

@cbachhuber cbachhuber force-pushed the linear-coordinate-transform branch from 752f5b9 to 62da82f Compare May 1, 2020 15:07
@cbachhuber
Copy link
Contributor Author

Ok cool, I rebased on your commit. With that, only the resolution dependency remains 👍

@TheCodez TheCodez merged commit 0333593 into TheCodez:master May 1, 2020
@cbachhuber cbachhuber deleted the linear-coordinate-transform branch May 3, 2020 17:09
@TheCodez TheCodez mentioned this pull request May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants