Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle worksheets via relationship ID rather than implicit names #16

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Handle worksheets via relationship ID rather than implicit names #16

merged 1 commit into from
Aug 21, 2020

Conversation

dglsparsons
Copy link
Contributor

@dglsparsons dglsparsons commented Aug 19, 2020 •
edited
Loading

Closes #15

@dglsparsons dglsparsons requested a review from a team as a code owner August 19, 2020 08:54
@dglsparsons
Copy link
Contributor Author

@AndyThurgood you're rubbish at doing timely reviews ;)

@AndyThurgood
Copy link
Contributor

@dglsparsons did you run this change against the .xls file that was supplied via #15 ?

AndyThurgood
AndyThurgood approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@AndyThurgood AndyThurgood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndyThurgood AndyThurgood merged commit c5a5506 into TheDataShed:master Aug 21, 2020
@dglsparsons
Copy link
Contributor Author

I did yeah - I used it as the test file iirc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyThurgood AndyThurgood AndyThurgood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File Not Found after deleting a worksheet
2 participants
@dglsparsons @AndyThurgood