Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle absence of shared strings file #19

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

dglsparsons
Copy link
Contributor

@dglsparsons dglsparsons commented Aug 21, 2020

Fixes #18

@dglsparsons dglsparsons requested a review from a team as a code owner August 21, 2020 11:11
@AndyThurgood
Copy link
Contributor

So this is def a fix. I wonder if we should raise an issue around the shared string implementation where we could refactor some of higher level code to handle such a potential absence. error.Is() feels like a yucky logic gate

@dglsparsons
Copy link
Contributor Author

It's a bit of a weird logic gate, true. Not so different to just throwing a FileNotFoundEXception and letting the caller deal with it though.

Realistically the code only really has one function (outside of some helpers in this file) that's called - getSharedStrings - which is responsible for loading the sharedstrings file and populating the contents into a consumable format. So as long as that handles it correctly, is it such an issue? :)

@AndyThurgood
Copy link
Contributor

AndyThurgood commented Aug 21, 2020

Not really, just figured we might be able to head it off earlier

Copy link
Contributor

@AndyThurgood AndyThurgood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndyThurgood AndyThurgood merged commit f13424b into TheDataShed:master Aug 21, 2020
@emilien-puget
Copy link

Hi, do you plan to make a new release tag for this fix ? If so, when ?
Thank you

@dglsparsons dglsparsons deleted the shared-strings branch August 24, 2020 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shared Strings XML not found
3 participants