Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAQ Hardware Documentation and DAQ_NI Update #672

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

EvoleneP
Copy link
Collaborator

The DAQ interface was throwing an error because n_samples == 0, and it did not know how to handle this condition. This arose because we had multiple digital signals, but no analog outputs configured. Software had not been tested under this condition.

The DAQ interface was throwing an error because n_samples == 0, and it did not know how to handle this condition. This arose because we had multiple digital signals, but no analog outputs configured. Software had not been tested under this condition.
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (c1d9ccb) 56.89% compared to head (fe8e912) 56.91%.

Files Patch % Lines
src/aslm/model/devices/daq/daq_ni.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #672      +/-   ##
===========================================
+ Coverage    56.89%   56.91%   +0.01%     
===========================================
  Files          152      152              
  Lines        16076    16078       +2     
===========================================
+ Hits          9147     9150       +3     
+ Misses        6929     6928       -1     
Flag Coverage Δ
unittests 56.91% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AdvancedImagingUTSW AdvancedImagingUTSW linked an issue Nov 15, 2023 that may be closed by this pull request
@AdvancedImagingUTSW AdvancedImagingUTSW merged commit a8fa902 into develop Nov 16, 2023
1 check passed
@AdvancedImagingUTSW AdvancedImagingUTSW deleted the evolene-branch1 branch December 15, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analog Output Error
2 participants