-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix more things in 1.20.5 port. #242
Conversation
…es/crashes, making it usable with more mods (tested with PolymaniaForks + my own polymer mods)
from 1.20.5 changelog, it says: |
It's best to not use that and fix the errors instead, as they will cause issues otherwise (and it will be removed, so for people using ViaVersion it's not great idea) |
Just for my understanding, why did you rewrite the tooltip transformer code? I presume to help support mods that mixin to |
From my testing it didn't work correctly originally (broke tooltips for items modified with polymer). Also yeah it fixes compat with mods adding things there, like trinkets. |
thats what i meant, some kind of packet filter or smth to only allow vanilla packets through if client is fully vanilla, but then that might break things like simple voice chat that send non vanilla packets. |
Non-vanilla packets aren't affected by the 1.20.5 change. They use special plugin channel packets which are meant to contain modded/arbitrary data. Instead, the change affects vanilla packets which contain references to modded data. This PR aims to remove/edit those references. |
is this a good place for issues that are using this pr? IssueVelocity -> Fabricoutput of `ls mods | clipcopy`
|
This has been merged manually, thanks! |
A bit of work on 1.20.5/6 port, improve items and fix some other issues/crashes, making it usable with more mods (tested with PolymaniaForks + my own polymer mods). There are likely still some issues/bugs, so it needs bit more testing.
Depends on TheEpicBlock/resource-locator-api#4