-
Notifications
You must be signed in to change notification settings - Fork 0
[TFF-170] Fix consusd
and allow port selection for integration tests
#69
Conversation
Codecov Report@@ Coverage Diff @@
## dev #69 +/- ##
==========================================
- Coverage 86.11% 85.87% -0.24%
==========================================
Files 16 16
Lines 360 361 +1
==========================================
Hits 310 310
- Misses 50 51 +1
Continue to review full report at Codecov.
|
consusd
and allow port selection for integration tests
Coverage isn't particularly achievable here, because the |
return (arg.match(/^--port=(\d+)$/) || [0, port])[1]; | ||
}, 80); | ||
|
||
var path = require('path'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does ES6 syntax not apply to this file for some reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. This file is not being transpiled by babel.
I suppose we could make a special source folder with es6 and transpile it into bin
with babel, but I don't know if that's worthwhile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Server started, url worked, server stopped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Summary
This pull request enables the integration test suite to start the server as a background process on a specific port.
Sister PRs (merge this PR first!):
Checklist
How to Review
functional-integration-TFF-170
branch onconsus
npm install -g
consusd start --port=8081
consusd stop
Links