Skip to content
This repository has been archived by the owner on Mar 5, 2018. It is now read-only.

Hotfix: Fix null object creation #75

Merged
merged 1 commit into from
Feb 5, 2017
Merged

Conversation

trevinhofmann
Copy link
Member

@trevinhofmann trevinhofmann commented Feb 5, 2017

Summary

Our null objects were created incorrectly. This fixes that.

https://www.bennadel.com/blog/2797-creating-objects-with-a-null-prototype-in-node-js.htm

Checklist

  • Have you added unit and functional tests as appropriate?
  • Did you update/add documentation for new methods or changed functionality?
  • Have you merged the target branch down into this one?

How to Review

  1. Review the code changes.

@codecov-io
Copy link

codecov-io commented Feb 5, 2017

Codecov Report

Merging #75 into dev will not impact coverage.

@@           Coverage Diff           @@
##              dev      #75   +/-   ##
=======================================
  Coverage   86.38%   86.38%           
=======================================
  Files          16       16           
  Lines         360      360           
=======================================
  Hits          311      311           
  Misses         49       49
Impacted Files Coverage Δ
src/store/checkin-store.js 96.15% <100%> (ø)
src/store/student-store.js 98.14% <100%> (ø)
src/store/item-store.js 95.65% <100%> (ø)
src/store/model-store.js 96.49% <100%> (ø)
src/store/checkout-store.js 90.9% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d9d511...594259a. Read the comment docs.

@gearedmonkey gearedmonkey merged commit c584c77 into dev Feb 5, 2017
@gearedmonkey gearedmonkey deleted the hotfix-null-objects branch February 5, 2017 16:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants