Enforce consistent indentation for arrays

[apalmer0]

# bad
in_a_method_call([
                  :its_like_this
                 ])

# good
in_a_method_call([
  :no_difference
])

documentation

[danfrenette]

I support this, but only from an aesthetic standpoint. I'm not aware of any practical benefits of one option or the other.

[apalmer0]

I think this is a purely aesthetic cop, so I don't know that there are any practical benefits to either. Unless you consider readability to be a practical benefit, in which case my opinion is that the "consistent" style is easier to read.

[kevin-j-m]

Does this consider the following valid/in adherence with the style:

array = 
[
  :value
]

and_in_a_method_call(
  [
    :value
  ]
)

[apalmer0]

Oh interesting, yeah @kevin-j-m you're right - that syntax satisfies either rule. So I guess the question is how do we feel about option 1 vs option 2? With EnforcedStyle: consistent either will work, with the rubocop default only option 2 works. Seems like we'd rather only have one option than two?

# option 1
method_call([
  :foo,
])

# option 2
method_call(
  [
    :foo,
  ],
)

[kevin-j-m]

So, for me, I'd consider it incredibly unlikely to in-line an array in a method call anyway, so I'm not sure I really care about the method formatting that much, but I would also prefer consistent to special_inside_parentheses were I to see it in a method call.

Is there a scenario where this is actually common that I'm neglecting to consider?

[danfrenette]

Is there a scenario where this is actually common that I'm neglecting to consider?

I can't think of any, for whatever that's worth

[danfrenette]

It looks like this needs a rebase because we spaced this. The style is solid though 👍