Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cargo.toml #4

Merged
merged 1 commit into from
Jan 21, 2020
Merged

Update Cargo.toml #4

merged 1 commit into from
Jan 21, 2020

Conversation

ammgws
Copy link
Contributor

@ammgws ammgws commented Jan 17, 2020

According to the link below this should decrease build times, example given is a twenty second reduction.

eminence/terminal-size#9

@TheKK
Copy link
Owner

TheKK commented Jan 21, 2020

Thanks for sending PR! Even though this project is almost abandoned, maybe it's good time to restart it again :P

About your fix, what do you think about changing the version of terminal_size to 1.0 without patch version, and add Cargo.lock to this crate?

According to the link below this should decrease build times, example given is a twenty second reduction.

eminence/terminal-size#9
@ammgws
Copy link
Contributor Author

ammgws commented Jan 21, 2020

I just made some changes, could you please check?

  • I assumed you meant changing it to 0.1 since 1.0 might have breaking changes.
  • I thought Cargo.lock isn't used for crates that are libraries so I left it

@TheKK
Copy link
Owner

TheKK commented Jan 21, 2020

I thought Cargo.lock isn't used for crates that are libraries so I left it

hmm, in that case maybe including patch version would be more appropriate ?

Here's the Cargo.toml of tokio-rs which including patch version:
https://github.com/tokio-rs/tokio/blob/master/tokio/Cargo.toml

@ammgws
Copy link
Contributor Author

ammgws commented Jan 21, 2020

"0.1" by itself should be fine as it translates to >=0.1 <0.2

From rust docs:

While SemVer says there is no compatibility before 1.0.0, Cargo considers 0.x.y to be compatible with 0.x.z, where y ≥ z and x > 0.

@TheKK
Copy link
Owner

TheKK commented Jan 21, 2020

That's great!

@TheKK TheKK merged commit 5703470 into TheKK:master Jan 21, 2020
@ammgws ammgws deleted the patch-2 branch January 21, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants