Skip to content

added offsetCount option to CustomListView Widget #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 23, 2020
Merged

added offsetCount option to CustomListView Widget #7

merged 2 commits into from
Aug 23, 2020

Conversation

RoduanKD
Copy link
Contributor

Context: When pulling data from WordPress API (V2) endpoint, the page query parameter doesn't accept zero.
offsetParam in NetworkListAdapter only accepts the parameter name and it doesn't cover the initial value.

Solution: I added an offsetCount option to the widget so if I want to start from page number eg 1, 2, 3 ... I just added offsetCount parameter.

Example:

CustomListView( 
  // What page to start from (default: 1)
  offsetCount: 1,
),

themisir
themisir requested changes Aug 23, 2020
View reviewed changes
@themisir themisir merged commit 30f0e5a into themisir:master Aug 23, 2020
@RoduanKD RoduanKD mentioned this pull request Aug 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themisir themisir themisir approved these changes

+1 more reviewer

@WaleedAlrashed WaleedAlrashed WaleedAlrashed left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RoduanKD @WaleedAlrashed @themisir