-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to create pdf roster #267
Comments
I had this same problem. This change fixed it. Hope it helps. |
Fantastic! It works perfectly!! Thanks!!! |
Seems that since last updates I get a similar error:
|
Hi Algomu, |
Same here, have been testing fresh and exisiting installs all week and no sign on this problem myself. A release was pushed last night if not already on that version, can you install that and see if it fixes it? The latest version contains patches to the PDF generating code. |
Hi! No, I get the same error. I tried to clone master and install the new branch and I get error in both installations:
The last version that works was naflm-BB2016-DZ2 modifying fpdf.php line 994:
But, then, the error was different... |
This is very weird, @algomu Can I ask you to do a couple things to help us identify why on your install this is happening;
@The-J-Bird by chance have you done a fresh install of NAFLM v1.1 Spike v9.1 on your host, and is it happening for you still also? |
@byrnesvictim, my permissions were 0644, I changed but error persists, I am using php 5.6 and a lot of browsers, safari, firefox and chrome, I can create you a test admin user if you want to see the error. |
Can you run /troubleshoot.php and post it here as well.
…On Thu, 16 Jul 2020, 18:03 algomu, ***@***.***> wrote:
@byrnesvictim <https://github.com/byrnesvictim>, my permissions were
0644, I changed but error persists, I am using php 5.6 and a lot of
browsers, safari, firefox and chrome, I can create you a test admin user if
you want to see the error.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#267 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD25NBTOG73SA4KU7LNDRGLR32X5JANCNFSM4IUA3A4Q>
.
|
Yes please. That would be great. |
This error would indicate that some whitespace is left after an ending PHP tag. For example:
?> with an enter would cause this if it was in the right location. Removing an end tag in some cases is good.
Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows 10
From: David<mailto:notifications@github.com>
Sent: Thursday, July 16, 2020 4:17 AM
To: TheNAF/naflm<mailto:naflm@noreply.github.com>
Cc: Subscribed<mailto:subscribed@noreply.github.com>
Subject: Re: [TheNAF/naflm] Unable to create pdf roster (#267)
@byrnesvictim<https://github.com/byrnesvictim>, my permissions were 0644, I changed but error persists, I am using php 5.6 and a lot of browsers, safari, firefox and chrome, I can create you a test admin user if you want to see the error.
Yes please. That would be great.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#267 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADGATDDOGM27NJQO34WZ4TTR32ZR3ANCNFSM4IUA3A4Q>.
|
I checked that early as well, the >? was removed from the pdf_roster.pdf some years ago.
|
test/bloodbowl!! |
|
If I comment line 487 on pdf_roster.php and it works!!!! Wizards line...
I remove comment on line 487 again... |
I have looked at all the files, there is a possible connection in one we are looking into. It is hard for us to test as we can't replicate the error. |
@algomu I logged in to your server and got the same errors, you can delete those credentials now. Can I you have time to try a totally new install with a fresh SQL database and also confirm that the problem still exists then? You do not have any html minify or similar going on by chance? |
Thanks, may be can be useful that seems to works if I comment this line:
|
No problem, but probably will be next monday, any recommendation? any different php version? |
I'm running and testing on 5.6, but there is work on a PHP7.x version of the software going on right now. Lets keep it at 5.6 so we can try and narrow down why it happens on your install. So it looks like a couple workarounds but would be nice to know why on some installs specifically this happens. |
Could display errors cause this problem by outputting data in the middle of the PDF causing this error message?
Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows 10
From: David<mailto:notifications@github.com>
Sent: Friday, July 17, 2020 7:40 AM
To: TheNAF/naflm<mailto:naflm@noreply.github.com>
Cc: williamleonard<mailto:william.leonard@hotmail.com>; Comment<mailto:comment@noreply.github.com>
Subject: Re: [TheNAF/naflm] Unable to create pdf roster (#267)
I'm running and testing on 5.6, but there is work on a PHP7.x version of the software going on right now. Lets keep it at 5.6 so we can try and narrow down why it happens on your install.
So it looks like a couple workarounds but would be nice to know why on some installs specifically this happens.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#267 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADGATDALSKFAMUOVDGNU7HTR4A2D5ANCNFSM4IUA3A4Q>.
|
I tried with fresh installation. I cloned master with: git clone https://github.com/TheNAF/naflm.git I modified settings.php with username, password database. I access to install.php:
Then, log in with root:
After, I created a new user, with that user a team, and finally create roster:
If I put a comment (//) on line 487, first Notice disappears, but second one persists. The mysql version is:
|
can you post your php extensions (screenshot) The problem I have is that I can't replicate the error, on any of the 3 test environments I have. And you just did a clean install. which leads me to suggest that it is something possibly server side. but i can't put my finger on it. might be best to post the host your paying. |
If it is a cpanel hosting and you want to send me a backup, I can restore it to cpanel and see if I can reproduce it as well and resolve it if I can. You can email the backup to support@mercuryvps.com<mailto:support@mercuryvps.com> .
Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows 10
From: thefloppy1<mailto:notifications@github.com>
Sent: Monday, July 20, 2020 7:21 PM
To: TheNAF/naflm<mailto:naflm@noreply.github.com>
Cc: williamleonard<mailto:william.leonard@hotmail.com>; Comment<mailto:comment@noreply.github.com>
Subject: Re: [TheNAF/naflm] Unable to create pdf roster (#267)
can you post your php extensions (screenshot) The problem I have is that I can't replicate the error, on any of the 3 test environments I have. And you just did a clean install. which leads me to suggest that it is something possibly server side. but i can't put my finger on it. might be best to post the host your paying.
Do you know what system resources you have?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#267 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADGATDEQYRWWLF44N6JDTUDR4TGNXANCNFSM4IUA3A4Q>.
|
Do this. that might be the best way to sort it out.
|
May http://bloodbowl.com.es:8000/phpinfo.php be enough? About my environment I send and email to @williamleonard explaining how to replicate, but I can draw a few notes here: I'm using docker and docker-compose, I creted two images, one for web and other for database: My images:
About the images, mysql is the default for that version but web, tagged as bloodbowl_web, was create with this Dockerfile:
And containers were created with this docker-compose.yml:
Thanks!! |
If you use the bb2016 rules, the 'Wizard' was renamed to 'Hireling Sports-Wizard'. In pdf_roster.php replace the 'Wizard' phrase on lines 373, 478, 491 with 'Hireling Sports-Wizard' and that error goes away. Not sure how to deal with this if you are not using the bb2016 ruleset. |
@algomu Can you try this fix for us please? |
Same errors after replace pdf_roster.php: Notice: Undefined index: Wizard in /var/www/html/modules/pdf/pdf_roster.php on line 487 Need I to run database synchronization? |
Seems that one error less with these changes: Notice: Undefined property: BB_PDF::$CurPageFormat in /var/www/html/modules/pdf/bb_pdf_class.php on line 370 About bb2016 rules, where can I choose activate or deactivate this rules? |
I missed the changed needed on line 487, the one it keeps prompting us to do... I've changed that one now also. I think with this build BB2016 is mandatory because there was some back end calculation stuff done |
After this last version wizard error disappears:
May be that I need to create a new issue for this error? I can't find how to apply BB2016 or not, I don't understand If I need to modify some parameter in any setting file or is always activated... |
I'll see if I can figure out this one: |
the fpdf library was updated from 1.6 to 1.82 The new version from the source removed the "CurentPageFormat" attribute. (I do not see the reason for that in the change log - http://www.fpdf.org/) . I am not finding a replacement for that attribute..I think, line 370 of bb_pdf_class.php is not needed and could be commented out. |
If I comment line 370 of bb_pdf_class.php works! Thanks to all!!! I will try a new clean installation with all changes... Thanks again |
Thank you for your effort, I have a question, I try this version after user OBBLM for several years. Each time I try to print roster pdf in my first installation I get:
Code related:
The text was updated successfully, but these errors were encountered: