-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Javascript Course, More Testing Lesson: Adds Resources for Dependency Injection #27405
Conversation
@@ -65,7 +65,7 @@ If we had written this program with TDD it is very likely that it would have loo | |||
### Assignment | |||
|
|||
<div class="lesson-content__panel" markdown="1"> | |||
1. If you haven't already, watch the 'mocking' videos from [this series](https://www.youtube.com/watch?v=3PjdxjWK0F0). | |||
1. If you haven't already, watch the 'mocking' videos from [this series](https://www.youtube.com/watch?v=3PjdxjWK0F0). The concept of dependency injection is mentioned quite a bit in this video, so if you are unfamiliar with the topic, you might want to read [this article](https://javascript.plainenglish.io/dependency-injection-in-javascript-539f7f6cfbee) first. If you prefer a video alternative, you can watch [this video](https://youtu.be/0X1Ns2NRfks?si=JrsXRvoe4FIHcOf0) until [03:50](https://youtu.be/0X1Ns2NRfks?si=-yQu7SvuFApoVhXw&t=230). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ManonLef was your intent in the original issue to include both an article and video here? Wondering if it makes more sense to include the video as an additional resource if it covers a bit more than the article does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is done exactly as proposed by @codyloyd in the original issue. I also would rather have both (video not in full length) since they are both great and this topic is not covered elsewhere I believe. I do think it's good for dependency injection to be covered. I don't know yet how common it is in the stack but it was a topic I had to learn quite a bit about in my workplace stack.
@CCeph is this the video that is sufficient to watch for the first x minutes only? If so, I'd prefer that mentioned due to the big amount of video material in this lesson.
@thatblindgeye are you okay with this or are you hesitant to cover it in the lesson or perhaps thinking it might be too out of scope?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is the video that should only be watched until 03:50. The assignment step already mentions this.
I understand that people could easily go down a rabbit hole if they miss the timestamp or simply decide to watch the whole video out of fear of missing out. I am not opposed to omitting the video entirely or including it in the additional resources with a timestamp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with including it if others feel it makes sense. I think I just partially lean more towards favoring articles over videos when we can, especially in this case where it's more of a "or watch the first few minutes of this video" rather than what feels like a "required" assignment item.
Either way, I'd say we should explicitly make them their own items rather than tacked on. So something more along the lines of:
1. If you haven't already, watch the 'mocking' videos from [this series](https://www.youtube.com/watch?v=3PjdxjWK0F0). The concept of dependency injection is mentioned quite a bit in this video, so if you are unfamiliar with the topic, you might want to read [this article](https://javascript.plainenglish.io/dependency-injection-in-javascript-539f7f6cfbee) first. If you prefer a video alternative, you can watch [this video](https://youtu.be/0X1Ns2NRfks?si=JrsXRvoe4FIHcOf0) until [03:50](https://youtu.be/0X1Ns2NRfks?si=-yQu7SvuFApoVhXw&t=230). | |
1. Read about [dependency injection in JavaScript](https://javascript.plainenglish.io/dependency-injection-in-javascript-539f7f6cfbee), as it is a concept mentioned quite a bit in the videos from the next assignment item. | |
1. Watch the [mocking videos by Fun Fun Function](https://www.youtube.com/watch?v=3PjdxjWK0F0). You only need to watch the linked video as well as the next two videos in his unit testing series ("mocking continued" and "red, green, refactor, and Jest mocks"). |
If we do want to include the video on injection still, then it could be added to the new assignment 1:
1. If you haven't already, watch the 'mocking' videos from [this series](https://www.youtube.com/watch?v=3PjdxjWK0F0). The concept of dependency injection is mentioned quite a bit in this video, so if you are unfamiliar with the topic, you might want to read [this article](https://javascript.plainenglish.io/dependency-injection-in-javascript-539f7f6cfbee) first. If you prefer a video alternative, you can watch [this video](https://youtu.be/0X1Ns2NRfks?si=JrsXRvoe4FIHcOf0) until [03:50](https://youtu.be/0X1Ns2NRfks?si=-yQu7SvuFApoVhXw&t=230). | |
1. Read about [dependency injection in JavaScript](https://javascript.plainenglish.io/dependency-injection-in-javascript-539f7f6cfbee), as it is a concept mentioned quite a bit in the next assignment item. If you prefer a video alternative, you can watch [dependency injection basics by Fun Fun Function](https://youtu.be/0X1Ns2NRfks?si=JrsXRvoe4FIHcOf0), up to the 3:50 timestamp only. | |
1. Watch the [mocking videos by Fun Fun Function](https://www.youtube.com/watch?v=3PjdxjWK0F0). You only need to watch the linked video as well as the next two videos in his unit testing series ("mocking continued" and "red, green, refactor, and Jest mocks"). |
(we shouldn't link to the video again for the 3:50 time stamp)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, we have this open PR that replaces the link for this assignment item: #26870
So this PR may actually depend on whether we want to keep the Fun Fun Function video in the assignment, or the one in this other PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you @thatblindgeye , the second option might be best. I am a tad attached to Fun Fun Functions because I think it's still very comprehensive. But it might be getting a bit outdated.
I have not gone through the whole other video (collection?) from the other resource, have you? I can't vouch for its quality.
Also are you still willing to work on this @CCeph ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any update on this? #28379 regards the Mocking video by FFF, so if we're planning to replace it with something else, then that'd also resolve the linked issue.
If needed, we can close this PR due to inactivity and open a new issue for someone to be assigned to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say replace the FFF video(s) for this lesson, two birds one stone and all. @MaoShizhong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thatblindgeye Just to confirm, the replacement link would be https://www.youtube.com/watch?v=ajiAl5UNzBU&t=3024s ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe so, yes. Been a minute since I looked at this or the 26870 PR, but that sounds accurate (unless anyone else has another suggestion for an alternative of course)
Because
Follow up to issue #26391. The "More Testing" lesson in the javascript course has a video that uses dependency injection frequently, but the students are never taught what dependency injection is. Hence, they can be overwhelmed or confused.
This PR
Issue
Closes #26391
Additional Information
N/A
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section