Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just updated harpoon and KABOOM! #546

Closed
wildfunctions opened this issue Apr 3, 2024 · 3 comments
Closed

Just updated harpoon and KABOOM! #546

wildfunctions opened this issue Apr 3, 2024 · 3 comments
Labels
bug Something isn't working harpoon2

Comments

@wildfunctions
Copy link

Lazy just now pulled a harpoon update, and when I tried to poon a file from my menu, got this explosion:

E5108: Error executing lua: ...bkim/.local/share/nvim/lazy/harpoon/lua/harpoon/list.lua:242: 'for' limit must be a number
stack traceback:
        ...bkim/.local/share/nvim/lazy/harpoon/lua/harpoon/list.lua:242: in function 'resolve_displayed'
        ...e/bkim/.local/share/nvim/lazy/harpoon/lua/harpoon/ui.lua:170: in function 'select_menu_item'
        ...im/.local/share/nvim/lazy/harpoon/lua/harpoon/buffer.lua:21: in function 'run_select_command'
        ...im/.local/share/nvim/lazy/harpoon/lua/harpoon/buffer.lua:61: in function <...im/.local/share/nvim/lazy/harpoon/lua/harpoon/buffer.lua:60>
@tommitah-heeros
Copy link

tommitah-heeros commented Apr 3, 2024

Looks like HarpoonUI:select_menu_item()'s usage of HarpoonList:resolve_displayed() is missing the second argument, which would be the length of the table. You can just add #list as a second argument to it and you'll be good to go. Could make a pr for this.

Blazing fast edit: looks like there already is a PR for this.

@Pranav-Badrinathan
Copy link

I spent far too long looking for breaking changes that I had not adapted to in my config that was causing this error. Glad to see there is a PR already.

@ThePrimeagen
Copy link
Owner

dude... i goofed. is this still an issue. i have updated harpoon and have several tests but i don't see this error at all

ThePrimeagen added a commit that referenced this issue Apr 3, 2024
Fix error on item select: Missing length argument (Resolves #546)
@ThePrimeagen ThePrimeagen added bug Something isn't working harpoon2 labels Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working harpoon2
Projects
None yet
Development

No branches or pull requests

4 participants