Deployment getting stuck at finalizing the build phase #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LookACastle
approved these changes
May 15, 2024
Yes, I've checked it on the test cluster and it worked |
…ing-stuck-at-finalizing-the-build-phase
iszulcdeepsense
deleted the
448-deployment-getting-stuck-at-finalizing-the-build-phase
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
Long deployments (over 20 minutes) no longer get stuck in the final stage.
This is done by switching to Server-Sent Events, sending heartbeat messages to keep alive the connection during long requests.
Plus, couple of improvements in FastAPI ASGI app to clean up the request properly (and show logs) if a client disconnects.