Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support deployment warnings #478

Merged
merged 10 commits into from
Jun 24, 2024
Merged

Support deployment warnings #478

merged 10 commits into from
Jun 24, 2024

Conversation

anders314159
Copy link
Contributor

First pass at supporting deployment warnings.

Added a new field 'warnings' to deployment schema, racetrack CLI now prints deployment warnings, and added a verify_manifest_consistency-warning.

Notes and questions:

  1. I mostly followed the implementation for deployment phases.
  2. How are DB migrations done in live environments?
  3. What other places should put warnings in the DB?

add new field 'warnings' to deployment schema, add a way to put warni…
fc48b3b 
…ngs in, racetrack CLI prints warnings, add verify_manifest_consistency-warning
@anders314159 anders314159 linked an issue Jun 17, 2024 that may be closed by this pull request
Support deployment warnings #473
Closed
iszulcdeepsense
iszulcdeepsense reviewed Jun 18, 2024
View reviewed changes
image_builder/image_builder/verify.py Show resolved Hide resolved
lifecycle/lifecycle/endpoints/deploy.py Outdated Show resolved Hide resolved
lifecycle/lifecycle/job/deployment.py Outdated Show resolved Hide resolved
racetrack_client/racetrack_client/client/deploy.py Outdated Show resolved Hide resolved
racetrack_client/racetrack_client/client/deploy.py Outdated Show resolved Hide resolved
@anders314159
Copy link
Contributor Author

Also remember the changelog

anders314159 and others added 2 commits June 20, 2024 12:53
@anders314159 @iszulcdeepsense
Update racetrack_client/racetrack_client/client/deploy.py
d18260e 
Co-authored-by: Ireneusz Szulc <45496492+iszulcdeepsense@users.noreply.github.com>
move logging for warnings to a more sensible places
bc7d4b8
@iszulcdeepsense iszulcdeepsense merged commit 677e324 into master Jun 24, 2024
2 checks passed
@iszulcdeepsense iszulcdeepsense deleted the 473-support-deployment-warnings branch June 24, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iszulcdeepsense iszulcdeepsense iszulcdeepsense approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support deployment warnings
2 participants
@anders314159 @iszulcdeepsense