Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn automatic reconciliation into a manual button #498

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Turn automatic reconciliation into a manual button #498

merged 4 commits into from
Jul 12, 2024

Conversation

iszulcdeepsense
Copy link
Collaborator

@iszulcdeepsense iszulcdeepsense commented Jul 11, 2024 •
edited
Loading

image

@iszulcdeepsense iszulcdeepsense linked an issue Jul 11, 2024 that may be closed by this pull request
Turn automatic reconciliation into a manual button #497
Closed
anders314159
anders314159 approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@anders314159 anders314159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Tested by deploying a job in kind, then deleting the deployment with kubectl. The job is now 'lost'. Pressing the button brings the job back.

@iszulcdeepsense iszulcdeepsense merged commit ffa9acf into master Jul 12, 2024
2 checks passed
@iszulcdeepsense iszulcdeepsense deleted the 497-turn-automatic-reconciliation-into-a-manual-button branch July 12, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anders314159 anders314159 anders314159 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Turn automatic reconciliation into a manual button
2 participants
@iszulcdeepsense @anders314159