Expanded Testing to 100% Coverage #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems out of the scope of this project.
The mixed syntax is less ambiguous
rzuckerm
suggested changes
Apr 4, 2023
|
Merging this for the time being. There are a variety of changes I'm looking to make before the module is finalized, so more testing will happen. |
That's fine. I wasn't sure if you wanted me to review this or now. |
|
I appreciated you taking a look at it! You've been very helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #106
The results of testing have minor implications on the Inline and Paragraph classes. Inline always followed a precedence of styling, but that precedence is now documented and tested. Paragraph receive a quality of life change allows for raw strings in the constructor. In that case, it's probably easier to just use add_paragraph, but I found many of my tests breaking due to not handling strings correctly. That's fixed now.