Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update bomber.py #343

Merged
merged 9 commits into from
Dec 27, 2021
Merged

update bomber.py #343

merged 9 commits into from
Dec 27, 2021

Conversation

iamkunal9
Copy link

@iamkunal9 iamkunal9 commented Dec 24, 2021

fixed error poor internet

Description

NOTE:

Fixes:

the motherfucker.com website is down and dont responding to ping req so changed it with google.com for universal purpose !

How Has This Been Tested?

tested in my pc

Checklist:

  • This PR fixes a reviewed issue.(If not create an issue first)

  • I have performed a self-review of my own code

  • My changes generate no new warnings

  • I have checked my code and corrected any misspellings

@0n1cOn3
Copy link
Contributor

0n1cOn3 commented Dec 24, 2021

Valid PR

@TheSpeedX please update asap!

@TheSpeedX
Copy link
Owner

@iamkunal9 The test site is still up and we won't use google.com to check internet as its banned in china.

@0n1cOn3
Copy link
Contributor

0n1cOn3 commented Dec 25, 2021

@iamkunal9 The test site is still up and we won't use google.com to check internet as its banned in china.

Rather to just use one URL, it would better to add a sec second validation to verify

@iamkunal9
Copy link
Author

@iamkunal9 The test site is still up and we won't use google.com to check internet as its banned in china.

Rather to just use one URL, it would better to add a sec second validation to verify

Yupp done!

@TheSpeedX
Copy link
Owner

Your fork with throw up exception if google.com is unreachable regardless if the test site is reachable or not.
Try to properly nest the try except blocks.

@iamkunal9
Copy link
Author

Your fork with throw up exception if google.com is unreachable regardless if the test site is reachable or not. Try to properly nest the try except blocks.

done! Now it should work

@TheSpeedX TheSpeedX changed the base branch from master to dev December 27, 2021 12:03
@TheSpeedX TheSpeedX merged commit 2ac0027 into TheSpeedX:dev Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.