Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if the application session key is available before access #3836

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

adriansmares
Copy link
Contributor

Summary

References https://www.thethingsnetwork.org/forum/t/internal-server-error/44472/3

This quickfix ensures that as.skipPayloadCrypto does not panic if a session is available, but the AppSKey is nil.

Changes

  • Add a nil-check for session.AppSKey

Testing

Tested locally with an unset AppSKey.

Regressions

Not expected.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added bug Something isn't working quickfix labels Feb 19, 2021
@adriansmares adriansmares added this to the February 2021 milestone Feb 19, 2021
@adriansmares adriansmares self-assigned this Feb 19, 2021
@github-actions github-actions bot added the c/application server This is related to the Application Server label Feb 19, 2021
@adriansmares adriansmares merged commit ff6b0b7 into v3.11 Feb 22, 2021
@adriansmares adriansmares deleted the fix/as-strengthen-session-check branch February 22, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c/application server This is related to the Application Server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants