Color pickers resetting back to default values when value is empty

[danyj]

The color pickers are resetting back to default value if empty value is saved.

http://take.ms/QU8In

'ddda' => array(
    'label' => __( 'RGBA Color Picker', 'unyson' ),
    'type'  => 'rgba-color-picker',
    'value' => '#ff6600',
    'desc'  => __( 'Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.',
        'unyson' ),
    'help'  => sprintf( "%s \n\n'\"<br/><br/>\n\n <b>%s</b>",
        __( 'Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.',
            'unyson' ),
        __( 'Sed ut perspiciatis, unde omnis iste natus error sit voluptatem accusantium doloremque laudantium',
            'unyson' )
    ),
),

You are left with visual reference that the value is empty until you refresh the page.
Users should be able to delete color value if they need to . Think of it this way, you set default blue color for button and user wants a button with no background. With current pickers they will never be able to do so.

[ghost]

Please test

[danyj]

What about this one
https://github.com/ThemeFuse/Unyson/blob/master/framework/includes/option-types/rgba-color-picker/class-fw-option-type-rgba-color-picker.php#L74

[danyj]

@moldcraft tested color picker , works thnx!
rgba color picker needs same fix

[danyj]

Rgba color picker , frontend works , backend still shows default value on page refresh
http://take.ms/7vhQR

[danyj]

this needs fixing

Unyson/framework/includes/option-types/rgba-color-picker/class-fw-option-type-rgba-color-picker.php

Line 56 in fa88a77

$option['attr']['value'] = empty($data['value']) ? $option['value'] : $data['value'];

[danyj]

this works for that line

$option['attr']['value'] = is_null($data['value']) ? $option['value'] : $data['value'];