[bug] wp-editor not adding brakes on first save

[danyj]

Video
https://monosnap.com/file/H664TMolqSEzHyTEs76zqi1o7p2Ghg

options to test

			'text' => array(
				'type' => 'wp-editor',
				'size' => 'large',
				'editor_height' => 200,
				'shortcodes' => true,
				'editor_type' => 'tinymce',
				'wpautop' => false,
				'label' => __('Content', 'fw'),
				'value' =>''
			),

on first save I get this

on second save I see brakes and even the p ,

as you can see in option wpautop is false

the wpautop has been lingering around this option since the first release.
It would be great to be fixed once and for all.

#1621

[danyj]

I tried to do , nl2br but on second save we have trouble since brakes and p are added so with nl2br second save gets 2 brakes each , and third one cleans it up. It is very hard to get this working.

Also the p is trouble inside headings , so there is no way to fix any of the issues until wpautop is fixed and we either get new line or brakes not both and not different on every save.

[ghost]

No need to save the post, it happens on modal save https://sendvid.com/zjlvgc0u

I haven't figure out a solution yet.

[ghost]

Please test

[danyj]

ok wpautop seems like it works , but now we have no more brakes but new lines when wpautop is false right?
so we must accommodate those with nl2br ?

[danyj]

ok I see you did try replacing it here
eba92e5#diff-58175d25bee5fa21b5af04e384540b24R83

maybe this one works better ?
http://stackoverflow.com/a/7467863/594423 ?

[danyj]

@moldcraft and this text/ visual tab bug , please see this till end
http://take.ms/i7NFH

tab works on first load until you save the popup, once you save popup and reopen tabs dont work anymore

[ghost]

When autop is off there are no <br> added.

This code is executed once on editor init.
You can delete editor content and write new text with new lines and it will not add `

[ghost]

Tabs work fine on my side. Please check browser console, maybe there is an error.

[danyj]

there are no errors I am looking at it , see the video please , you must save the popup to see the bug , not just open/close

[ghost]

I have saved it many times.

[danyj]

ok fixed the tab , it was my typography option had this on doc click event.stopImmediatePropagation();
sorry thnx for looking at that now to the br's and line brakes

autop is false

do this on line 84

Unyson/framework/includes/option-types/wp-editor/static/scripts.js

Line 84 in eba92e5

console.log(initialContent.replace(/\r?\n/g, '<br />'));

I see this

but output is

so I have to accommodate and check if br is there if not do nl2br

what I am sayings that when autop is false , we should replace new lines with brakes
if autop is true editor would do this automatically right?

[ghost]

console.log(initialContent.replace(/\r?\n/g, '<br />'));

Initially I set the editor content with <br> because there is no other way to preserve new lines in editor. If I set "Hello\r\nWorld" the editor shows one line.

check if br is there if not do nl2br

It should be always without br

if autop is true editor would do this automatically right?

Yes.

[danyj]

im bit lost now but all I am trying to do is match the visual to the output and currently we dont have that unless we massage the output

so if you have autop false and to this

one 
two
three

your output is this

one two three

if autop is true

visual

one 
two
three 

output

<p>
one <br />
two <br />
three
</p>

in my opinion autop false should produce this

one <br />
two <br />
three

since autop false does not mean strip all tags but strip p tag

[ghost]

autop is a WP feature, you should contact WP core devs to ask for feature requests.

This this in browser console

var text = "Hello\r\nWorld\r\nFoo",
    textautop = wp.editor.autop(text);
console.log(textautop);
console.log(wp.editor.removep(textautop));

output

<p>Hello<br />
World<br />
Foo</p>

Hello
World
Foo

[danyj]

you should contact WP core devs to ask for feature requests.

cmon man dont be so harsh , I am trying to make sense out of it and you must admit that it makes no sense to see one thing in editor and get different result

[ghost]

I tried to disable auto for default post content editor via this filter

add_filter('tiny_mce_before_init', function ($mceInit) {
	$mceInit['wpautop'] = false;
	return $mceInit;
});

but it doesn't disable autop. In js the parameter is set

tinyMCEPreInit.mceInit['content'].wpautop

I tried to disable autop for default editor to show that it works the same as I described above (without br)