Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and move @types/node to dev updates #183

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Update and move @types/node to dev updates #183

merged 2 commits into from
Jun 27, 2023

Conversation

askoufis
Copy link
Contributor

@types/node should not be a dependency for find-root since it doesn't expose any of the node types in its API, so I've moved it to a dev dep. I also updated the version to the last Node 16 types version. I chose Node 16 as it's the same version used in CI.

Fixes #118.

@changeset-bot
Copy link

changeset-bot bot commented Jun 27, 2023

🦋 Changeset detected

Latest commit: 6b4bb90

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@manypkg/find-root Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Andarist Andarist merged commit e03c0a3 into Thinkmill:main Jun 27, 2023
2 checks passed
@askoufis askoufis deleted the types-node-dev-dep branch June 27, 2023 07:21
@github-actions github-actions bot mentioned this pull request Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move @types/node to devDependencies?
2 participants