Adding week count and label via parameter #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThisIsBenny
requested changes
Sep 19, 2022
| de: ['Tag', 'Tage'], | ||
| default: ['Day', 'Days', 'weeks'], | ||
| en: ['Day', 'Days', 'Weeks'], | ||
| de: ['Tag', 'Tage', 'Wochen'], | ||
| fr: ['Jour', 'Jours'], | ||
| es: ['día', 'días'], | ||
| it: ['giorno', 'giorni'] |
There was a problem hiding this comment.
Please add "Weeks" also to fr, es, and it.
| @@ -17,6 +17,7 @@ if (widgetInputRAW !== null) { | |||
| } | |||
| dateForCountdown = widgetInput[0].trim() | |||
| icon = widgetInput[1] || '⏳'; | |||
| text = widgetInput[3]; // new | |||
There was a problem hiding this comment.
Please make this "optional" to avoid breaking changes: Use "Countdown" as fallback value in case there is no text defined
Comment on lines
+103
to
+107
| let provider2 = widget.addText(remainingWeeks+ " " + (t[2])) | ||
| provider2.font = Font.mediumSystemFont(16) | ||
| provider2.textColor = textColor | ||
| provider2.centerAlignText() | ||
| textStack.addSpacer() |
There was a problem hiding this comment.
- please use a separated horizontal stack with a spacer at beginning and end, and not the one from the remaining days (textStack).
- Please make this part configurable, because maybe not everyone would like to see also the remaining weeks
Ceemeemack
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.