Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET 8 support and also fix NU1903 NuGet.Protocol' 5.11.3 has a known high severity vulnerability warning #5

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

solrevdev
Copy link
Contributor

See #4

@ThomasArdal
Copy link
Owner

ThomasArdal commented Nov 21, 2023

Thanks! I forgot how this works. If the project only targets .NET 8, users need .NET 8 installed, right? If we target both .NET 6 and 8, people can still run it with "only" .NET 6 installed?

@solrevdev
Copy link
Contributor Author

Thanks! I forgot how this works. If the project only targets .NET 8, users need .NET 8 installed, right? If we target both .NET 6 and 8, people can still run it with "only" .NET 6 installed?

No worries, yes that's exactly right. by adding the following you support multiple frameworks so folk with the old LTS .NET 6 only can still use it and anyone with the newer .NET 8 can also use it.

 <TargetFrameworks>net6.0;net8.0</TargetFrameworks>

I did upgrade the nuget packages so perhaps check they still support .NET6 with the new versions but I am sure they are fine. I can't see them dropping support just yet. Just adding etc

@ThomasArdal
Copy link
Owner

I think having both .NET 6 and .NET 8 in there is fine then. I tested the code with the updated packages. Works great 👯 Thank you very much.

@ThomasArdal ThomasArdal merged commit 3980f63 into ThomasArdal:main Nov 21, 2023
1 check passed
@solrevdev solrevdev deleted the solrevdev/dotnet8 branch November 21, 2023 15:07
@solrevdev
Copy link
Contributor Author

I think having both .NET 6 and .NET 8 in there is fine then. I tested the code with the updated packages. Works great 👯 Thank you very much.

And I only have .NET 8 installed and it works great for me on macOS 14.1.1 (23B81).

FYI it installed 1.0.30 for me which looks right to me

Thanks for merging and sorting so quick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants