Skip to content

Commit

Permalink
Merge pull request #147 from ThomasAribart/build-project-with-prev-ve…
Browse files Browse the repository at this point in the history
…rsion-of-TS

fix: build project with prev version of TS
  • Loading branch information
ThomasAribart authored May 27, 2023
2 parents f663fa3 + eec0c61 commit 01f639b
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
8 changes: 5 additions & 3 deletions .github/actions/install-node-modules/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@ name: Install Node Dependencies
description: Install dependencies using yarn
inputs:
node-version:
description: Node version to use
required: true
typescript-version:
required: true
description: TS version to use
default: "default"
runs:
using: composite
steps:
Expand Down Expand Up @@ -37,6 +39,6 @@ runs:
run: if [ '${{ steps.sync-node-modules-cache.outputs.cache-hit }}' != 'true' ]; then yarn install --immutable; fi
shell: bash

- name: Override TS with correct version
run: if [ '${{ steps.sync-node-modules-cache.outputs.cache-hit }}' != 'true' ]; then yarn add --dev typescript@${{ inputs.typescript-version }}; fi
- name: Override TS with specified version
run: if [ '${{ inputs.typescript-version }}' != 'default' ] && [ '${{ steps.sync-node-modules-cache.outputs.cache-hit }}' != 'true' ]; then yarn add --dev typescript@${{ inputs.typescript-version }}; fi
shell: bash
3 changes: 2 additions & 1 deletion .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ jobs:
strategy:
matrix:
node: [16, 18]
typescript: ["~4.5.5", "~4.6.4", "~4.7.4", "~4.8.3", "~4.9.5", "~5.0.4"]
typescript:
["default", "~4.6.4", "~4.7.4", "~4.8.3", "~4.9.5", "~5.0.4"]
name: Node ${{ matrix.node }} / TS ${{ matrix.typescript }}
steps:
- uses: actions/checkout@v3
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ jobs:
uses: ./.github/actions/install-node-modules
with:
node-version: 18
typescript-version: ~4.9.5

- name: Clear lib directory
run: rm -rf lib
Expand Down

0 comments on commit 01f639b

Please sign in to comment.