CollinearityThreshold bug fix and speedup #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s an out of range error on the `index[0]` call
ThomasBury
approved these changes
Feb 9, 2024
ThomasBury
approved these changes
Feb 9, 2024
ThomasBury
approved these changes
Feb 9, 2024
ThomasBury
requested changes
Feb 9, 2024
There was a problem hiding this comment.
While dividing isn't essential, skipping it could be confusing. We're aiming to find the feature with the highest collinearity. First, we combine the upper and lower halves of the association matrix (since it's not symmetrical). Then, dividing by 2 gives the average and ensures the values never exceed 1, avoiding misinterpretations.
ThomasBury
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #40
This probably should have some tests along with it, but I have wanted to get a PR started with my suggested changes.