Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript migration V1 #6

Merged
merged 17 commits into from
Oct 26, 2022
Merged

Typescript migration V1 #6

merged 17 commits into from
Oct 26, 2022

Conversation

techster10173
Copy link
Contributor

Transformed all JS files from alpha release to TS

@techster10173 techster10173 linked an issue Sep 28, 2022 that may be closed by this pull request
Migrate JS-SDK to TS #1
Closed
srawulwar
srawulwar approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@srawulwar srawulwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I acknowledge the changes and understand every line of code written down. Room for improvement but good work overall. lgtm

@techster10173 techster10173 merged commit fe32691 into main Oct 26, 2022
@techster10173 techster10173 deleted the typescript-migration branch October 26, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srawulwar srawulwar srawulwar approved these changes

@vlasp vlasp vlasp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate JS-SDK to TS
4 participants
@techster10173 @vlasp @srawulwar @hersheyg0105