add function for subscriber/publisher to reuse nats streaming connection #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fan Shang Xiang <fanshangxiang@gmail.com>
roblaszczak
requested changes
Mar 6, 2019
Signed-off-by: Fan Shang Xiang <fanshangxiang@gmail.com>
|
Sorry for opening pr before change set is ready. Could you please review the change set? Any comments are appreciated. |
|
CI build failed due to config file missing. |
|
CI is in progress (#59). Locally it does work. Thanks for the contribution 🍺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issue: #57
to resue Nats Streaming connection
Signed-off-by: Fan Shang Xiang fanshangxiang@gmail.com