Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ocelot to .NET 8 #1787

Closed
ggnaegi opened this issue Nov 17, 2023 · 5 comments · Fixed by #1789 or #1790
Closed

Ocelot to .NET 8 #1787

ggnaegi opened this issue Nov 17, 2023 · 5 comments · Fixed by #1789 or #1790
Assignees
@ggnaegi
Labels
accepted Bug or feature would be accepted as a PR or is being worked on feature A new feature high High priority hotfix Gitflow: Hotfix issue, PR related to hotfix branch release Pre/Release (minor, major)

Comments

@ggnaegi
Copy link
Member

ggnaegi commented Nov 17, 2023 •
edited
Loading

Expected Behavior / New Feature

.NET 8 was launched this week, so we expect Ocelot to be compatible with .NET 8 as soon as possible. 😸

Actual Behavior / Motivation for New Feature

Only supporting .NET 7

Specifications

  • After a chat with @RaynaldM, we should provide .NET8 and .NET7 support for the Ocelot sources (<TargetFrameworks> and Item groups with conditions)
  • After yet another chat with @raman-m we should provide .NET6 support too...
  • Tests and examples are targeting .NET8, .NET7 and .NET6 if possible
    ☕ 🥃 😸
@ggnaegi ggnaegi mentioned this issue Nov 17, 2023
Closed
@raman-m
Copy link
Member

raman-m commented Nov 18, 2023 •
edited
Loading

⚠️⚠️⚠️
❗Important❗
Feature branch is release/net8. It is created from main.
Delivery process is based on Gitflow Hotfix one.
That means, this feature (upgrade) should be delivered first, before Oct'23!

@raman-m raman-m added feature A new feature accepted Bug or feature would be accepted as a PR or is being worked on release Pre/Release (minor, major) hotfix Gitflow: Hotfix issue, PR related to hotfix branch high High priority labels Nov 18, 2023
@raman-m
Copy link
Member

raman-m commented Nov 18, 2023

Tests and examples are targeting .NET8

I'm not sure about this. If the lib targets multiple frameworks then why should tests target only one framework?

@raman-m raman-m mentioned this issue Nov 18, 2023
Merged
@ggnaegi
Copy link
Member Author

ggnaegi commented Nov 18, 2023 •
edited
Loading

Ok, let's begin from scratch again, to summarize:

  • using release/net8 branch
  • Targeting net6;net7;net8
  • Updating config, making sure that we are using 2 whitespaces for indent in xml files
  • Tests and Samples should, if feasible, target to net6;net7 and net8 too
    👨🏼‍🚀

@raman-m
Copy link
Member

raman-m commented Nov 18, 2023

During last month I have been thinking about release strategy. On some day we will have to decide on versioning and release strategy. It seems today is this day...

The old school release strategy was

  • separate release branch for each version
  • multiple building pipelines for each version
  • supporting a version via back porting of features & bugfixes
  • releasing each version separately

But when .NET 6 provided multi targeted frameworks feature everything was changed, and release strategy could be more simplest if changes are .NET versioning only.
Also, git repo back porting doesn't make sense anymore. Support can be organized using one repo and one release branch, having one code base. But in this modern approach we have to use more preprocessor directives.

Let's try this approach and we will see how it's useful... This release strategy requires less resources.

@ggnaegi ggnaegi mentioned this issue Nov 19, 2023
Merged
@raman-m raman-m linked a pull request Nov 19, 2023 that will close this issue
#1787 Upgrade to .NET 8 #1789
Merged
raman-m added a commit that referenced this issue Nov 19, 2023
@ggnaegi @raman-m
#1787 Upgrade to .NET 8 (#1789)
24b507e 
* Upgrade solution's projects to .net 8

* using .net 7.0 and .net 8.0 as target frameworks, adding conditions

* checking indentation. Should it be 1,2,3 or 4?

* target frameworks .net6.0, .net7.0 and .net8.0

* xml indentation

* let's check this one...

* some more cleanup

* consolidate stylecop version

* updating dockerfile.base to .net8

* udpating docker image build version to 0.0.10

* update config, maybe with some luck...

* downstream service only available for .net 7

* adding indication about ISystemClock in .NET8

* adding comments for ClientWebSocketOptionsProxy

* VS version vs .NET 8 SDK

* Warning ASP0019 Use IHeaderDictionary.Append or the indexer to append or set headers. IDictionary.Add will throw an ArgumentException when attempting to add a duplicate key.

* updated config

* Update Docker images & CircleCI config

* ocelot2/circleci-build:latest

* Use image: ocelot2/circleci-build:latest

* our friend GivenThereIsAPossiblyBrokenServiceRunningOn is back. I allow myself to push this fix - already implemented in the develop branch -

---------

Co-authored-by: raman-m <dotnet044@gmail.com>
@raman-m raman-m mentioned this issue Nov 19, 2023
Merged
@raman-m raman-m linked a pull request Nov 19, 2023 that will close this issue
Release 21.0 #1790
Merged
@raman-m
Copy link
Member

raman-m commented Nov 21, 2023

Implemented and delivered by #1790

@raman-m raman-m closed this as completed Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ggnaegi ggnaegi

Labels
accepted Bug or feature would be accepted as a PR or is being worked on feature A new feature high High priority hotfix Gitflow: Hotfix issue, PR related to hotfix branch release Pre/Release (minor, major)
Projects
None yet
Milestone
No milestone
2 participants
@raman-m @ggnaegi