This repository has been archived by the owner on Dec 10, 2018. It is now read-only.
Update parser.py #270
Merged
Update parser.py #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Full explanation is here : Thriftpy#269 and here : python-happybase/happybase#148
ErKatz
added a commit
to ErKatz/happybase
that referenced
this pull request
Dec 6, 2016
On non-Windows systems: things stay as they are On windows system: it would pass the path to the thrift file with "file://" scheme. If ThriftPY is fixed to handle the 'file' scheme - things would work on windows. Until then, things will stay broken, as they are now. This is further discussed here: python-happybase#148 and here: Thriftpy/thriftpy#269 NOTE: I created a corresponding fork and pull request on thrifypy as well: Thriftpy/thriftpy#270
|
Corresponding code change and pull request have been submitted to HappyBase as well. |
|
Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full explanation is here : #269
and here : python-happybase/happybase#148