Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dependencies from setup.py to project.toml #291

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

cocolato
Copy link
Contributor

@cocolato cocolato commented Jul 8, 2024

Fix the error when run python -m build:

        ********************************************************************************
        The following seems to be defined outside of `pyproject.toml`:

        `optional-dependencies = {'dev': ['flake8>=2.5', 'sphinx-rtd-theme>=0.1.9', 'sphinx>=1.3', 'pytest-reraise', 'pytest<8.2.0,>=6.1.1', 'tornado<7.0,>=4.0; python_version >= "3.12"', 'tornado<6.0,>=4.0; python_version < "3.12"'], 'tornado': ['tornado<7.0,>=4.0; python_version >= "3.12"', 'tornado<6.0,>=4.0; python_version < "3.12"']}`

        According to the spec (see the link below), however, setuptools CANNOT
        consider this value unless `optional-dependencies` is listed as `dynamic`.

        https://packaging.python.org/en/latest/specifications/pyproject-toml/#declaring-project-metadata-the-project-table

        To prevent this problem, you can list `optional-dependencies` under `dynamic` or alternatively
        remove the `[project]` table from your file and rely entirely on other means of
        configuration.
        ********************************************************************************

@cocolato cocolato force-pushed the feat/migrate_pyproj branch 3 times, most recently from 06faa3a to 90f32fb Compare July 8, 2024 14:12
@cocolato cocolato changed the title Feat/migrate pyproj Move dependencies from setup.py to project.toml Jul 8, 2024
setup.py Outdated Show resolved Hide resolved
Comment on lines 17 to +21
try:
from tornado import version as tornado_version
if tornado_version < '5.0':
tornado_requires.append("toro>=0.6")
dev_requires.append("toro>=0.6")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aisk Do you think this implementation makes sense now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tornado support will be deprecated, so I think this is ok for me.

@cocolato cocolato requested a review from aisk July 8, 2024 15:11
@ethe ethe merged commit 8e226b1 into Thriftpy:master Jul 10, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants