Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completely rewrites
TibiaBoostableBossesOverviewImpl
The reason behind this rewrite is to stop using regex and goquery. The performance boost is gigantic, reducing allocations from over 8000 to just 3.
I also needed to modify
TibiaDataHTMLDataCollector
slightly allowing aRawBody
flag to be passed to itIf this flag is passed, we pass tibia.com's response directly to the caller instead of creating a document using
goquery
This does not interfere with any other parser, because in other for this change to take place the
RawBody
flag must be specified.old.txt
new.txt