Fix duplicated search result in advanced search #8485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed: Leilei332 has already signed the Contributor License Agreement (see contributing.md) |
Leilei332
changed the title
|
Thanks @Leilei332 this PR fixes a problem that appears to have been introduced in #7889. I wonder if the code might be less confusing if we adopted the conditional shortcut? For consistency we'd need to do it to all the related advanced search templates. |
Leilei332
force-pushed
the
fix-extra-search
branch
from
4f23b8b
to
5205080
Compare
|
I think we had better use the After testing in The uglifier, I found that the advanced search worked well. Looks like the uglify plugin has been updated to support 5.3.x versions. IMO there is no need to worry about backward capability for it. |
|
Thanks @Leilei332 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the appearance of duplicated search results in advanced search when more than one tiddlers are tagged with
$:/tags/SearchResults.