-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add copy_to2 #72
add copy_to2 #72
Conversation
Thank you so much, this looks great. Idk why the documenter is failing, this is something with a recent julia or documenter update because I am newly having this issue as well. As for the PR, a few small changes if you dont mind - Can you add these changes to the MySQL extension - this will allow us to keep MySQL, DBInterface, and CSV as weakdeps to keep the package light. You can still leave it as a separate file in the ext fold, but just need to include it in underneath
For I have not tried running a docstring from an ext file. If it gives you issues, dont worry about it and i can try sorting it out/putting in a thank you! |
I added the code to the ext as recommended; I have no idea how to test it locally. I guess it is time to learn about extensions... |
Ok this is near perfect.. last thing (im sorry since I dont actually know how to take over a PR yet and easily edit it) can you change the argument order in as for the deps, it looks like MySQL, CSV, DBInterface are still in and then ill merge and release asap.. just finishing up one other refinement to allow multiple TidierDB queries to be joined in a single chain As far as local testing goes.. I too am not sure how to best do this for non duckdb backends. I've written about 60 TidierDB to tidierdata duckdb backend tests but I'm not sure how to best blanket those to the other 10 backends EDIT |
No problem! See if it's ok now. |
Looks. Good last thing is like 54 |
Ops! The "end" got into the mess. Fixed. |
I messed a bit with the project.toml to add CSV and MySQL; I also created the file copy_to.jl where I wrote a draft of how to make inserts in MariaDB from julia dataframes. I called my new function
copy_to2
to avoid clashes with the other one.Its arguments are
where we need a dataframe, a table_name (in the database), a connection (for now, just the MySQL/MariaDB), and the replace argument (which is false by default).