-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build fixes to libvnc.so for Xorg-server-21.1.1 #1383
Conversation
VENDOR_STRING is gone as is DEFAULT_LOG_VERBOSITY site.h has been removed and is not needed.
478cb3b
to
2a659bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Most of this looks fine. But I think it's safer to clone of the patch file, just like we've done previously. Avoids issues in case we need to do further tweaks in the future for 21.
PS. I thought 21 required Meson?
2a659bd
to
0c5a2b2
Compare
Done.
I think they just added meson but the old autotools system is still there. |
Just remembered, the patching miinitext.c look odd, is that really needed? |
That's so that Xvnc is built correctly, so I'm afraid it is needed. We also use internal APIs, so we will always need to be built in the Xorg source tree. |
I see, does that extend to the libvnc.so Xorg module as well? |
Yup. That's why it needs to be rebuilt when Xorg changes. I think the only somewhat stable API is the graphics driver API, and we need more than that. |
This makes libvnc Xorg module against Xorg-server-21.1.1.
Note that now one must enable present support in Xorg to make
libvnc build.
Only build tested though.