Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fixes to libvnc.so for Xorg-server-21.1.1 #1383

Merged
merged 3 commits into from
Nov 26, 2021

Conversation

joakim-tjernlund
Copy link
Contributor

This makes libvnc Xorg module against Xorg-server-21.1.1.
Note that now one must enable present support in Xorg to make
libvnc build.

Only build tested though.

VENDOR_STRING is gone as is DEFAULT_LOG_VERBOSITY
site.h has been removed and is not needed.
Copy link
Member

@CendioOssman CendioOssman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Most of this looks fine. But I think it's safer to clone of the patch file, just like we've done previously. Avoids issues in case we need to do further tweaks in the future for 21.

PS. I thought 21 required Meson?

@joakim-tjernlund
Copy link
Contributor Author

Thanks. Most of this looks fine. But I think it's safer to clone of the patch file, just like we've done previously. Avoids issues in case we need to do further tweaks in the future for 21.

Done.

PS. I thought 21 required Meson?

I think they just added meson but the old autotools system is still there.

@CendioOssman CendioOssman merged commit 0c5a2b2 into TigerVNC:master Nov 26, 2021
@joakim-tjernlund
Copy link
Contributor Author

Just remembered, the patching miinitext.c look odd, is that really needed?
If not one could just build libvnc against an already installed Xorg and remove the patching competently.
Then tigervnc does not have to bother with meson later on either.

@samhed samhed added the bug Something isn't working label Nov 26, 2021
This was linked to issues Nov 26, 2021
@CendioOssman
Copy link
Member

That's so that Xvnc is built correctly, so I'm afraid it is needed. We also use internal APIs, so we will always need to be built in the Xorg source tree.

@joakim-tjernlund
Copy link
Contributor Author

That's so that Xvnc is built correctly, so I'm afraid it is needed. We also use internal APIs, so we will always need to be built in the Xorg source tree.

I see, does that extend to the libvnc.so Xorg module as well?

@CendioOssman
Copy link
Member

Yup. That's why it needs to be rebuilt when Xorg changes. I think the only somewhat stable API is the graphics driver API, and we need more than that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support xorg-server 21.x seg fault after xorg update
3 participants