Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the udev to call the non-sudo python version #17

Closed
wants to merge 1 commit into from

Conversation

glemaitre
Copy link

It is what I mean in the PR #16

@coveralls
Copy link

Coverage Status

Coverage remained the same at 51.621% when pulling fbf01fa on glemaitre:setup_conda_fix into ba4c276 on Tigge:master.

@Tigge
Copy link
Owner

Tigge commented Sep 23, 2016

It is a bit better than the previous solution but I'm still not convinced, could you provide a bit more background as to what is the problem and why. If you are still interested please reopen as you see fit, thank you.

@Tigge Tigge closed this Sep 23, 2016
@glemaitre
Copy link
Author

This is long time a ago but if I recall well, the issue was the following. The current setup.py script request to be executed as super-user (su). However, doing so, the python distribution used will be always the system one even with anaconda environment (or conda, virtualenv, or pip I supposed).

After some thoughts the current solution and this PR are wrong. This PR will not work if the user rely on the python system as in Ubuntu. You will need the sudo privileges to install it. However, the current solution is not working for the previous user-based environment mentioned.

So what seems to be the best is to split both udev and python package install. The udevadm and cp can be placed in a Makefile or a separate script. Therefore, the python setup file will only handle only python package related stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants