Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for continuous scan mode #52

Closed
wants to merge 1 commit into from
Closed

Conversation

dittons
Copy link

@dittons dittons commented Aug 22, 2020

See paragraph 9.5.4.5 Open Rx Scan Mode of ANT Message Protocol

@coveralls
Copy link

coveralls commented Aug 22, 2020

Coverage Status

Coverage decreased (-0.08%) to 57.311% when pulling 2c53e59 on dittons:master into ae9e736 on Tigge:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 57.243% when pulling 2c53e59 on dittons:master into ae9e736 on Tigge:master.

@@ -243,6 +243,10 @@ def open_channel(self, channel):
message = Message(Message.ID.OPEN_CHANNEL, [channel])
self.write_message(message)

def open_rx_scan_mode(self,channel,syncmsgsonly):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I see in the documentation, its not actually a channel parameter. Marked as fillet, but is weirdly present in the api as a parameter.

Seems to only be available on channel 0.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to only be available on channel 0.

Yes, Documentation says:
Execution of this command causes channel 0 to commence operation in continuous scanning mode.
Channel 0 should have been previously assigned and configured as a slave receive channel.
In this mode no other channels may operate when the node is in continuous scanning mode.

@@ -67,6 +67,10 @@ def open(self):
self._ant.open_channel(self.id)
return self.wait_for_response(Message.ID.OPEN_CHANNEL)

def open_rx_scan_mode(self, syncmsgsonly):
self._ant.open_rx_scan_mode(self.id,syncmsgsonly)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably throw an error if we arr not on channel 0.

@drkingpo
Copy link
Contributor

drkingpo commented Oct 21, 2020

This pull request could be closed now, as PullRequest: #54 is merged and include this also.

@Tigge Tigge closed this Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants