Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use GNU readline for auto completion #68

Closed
wants to merge 7 commits into from

Conversation

BruceKangCN
Copy link

No description provided.

@Hagb
Copy link
Contributor

Hagb commented Feb 12, 2021

To use GNU readline licensed under GPL, maybe mcrcon should also be licensed under GPL too.

@Tiiffi
Copy link
Owner

Tiiffi commented Feb 12, 2021

Hi,

I think this is very good addition but the only problem I have with getline is that it adds dependency which may cause problems on different platforms. I am also trying to keep mcrcon simple and easy to compile with reasonably minimal dependencies.

I think the best solution is to make the getline support optional. Perhaps using makefile option like this: make getline=1


@Hagb

To use GNU readline licensed under GPL, maybe mcrcon should also be licensed under GPL too.

As fas as I know Zlib license is compatible with GPL so there shouldn't be any problem with that.

@Tiiffi Tiiffi requested review from Tiiffi and removed request for Tiiffi February 12, 2021 23:41
@Hagb
Copy link
Contributor

Hagb commented Feb 13, 2021

@Tiiffi

As fas as I know Zlib license is compatible with GPL so there shouldn't be any problem with that.

Sorry for my misunderstanding about GPL-compatibility. You are right.
https://www.gnu.org/licenses/gpl-faq.html#IfLibraryIsGPL

@Tiiffi Tiiffi deleted the branch Tiiffi:develop October 30, 2021 19:35
@Tiiffi Tiiffi closed this Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants