Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable automatic upload to pypi #2034

Merged
merged 6 commits into from
Oct 3, 2024
Merged

Re-enable automatic upload to pypi #2034

merged 6 commits into from
Oct 3, 2024

Conversation

dudoslav
Copy link
Collaborator

@dudoslav dudoslav commented Aug 5, 2024 •
edited
Loading

Do not forget to prepare the release environment (pypi)

^^ The release environment should be prepared.

[sc-54205]

@dudoslav dudoslav self-assigned this Aug 5, 2024
@dudoslav dudoslav changed the title Re-enable automatic upload to pypi Draft: Re-enable automatic upload to pypi Aug 5, 2024
ihnorton
ihnorton requested changes Aug 5, 2024
View reviewed changes
Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add a test against S3 and tiledb:// before we turn this on unconditionally.

@kounelisagis kounelisagis marked this pull request as draft August 6, 2024 13:34
ihnorton
ihnorton reviewed Aug 29, 2024
View reviewed changes
Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Let's remove s3 since we are using core binaries that are already tested
  • Let's do a write and a read to tiledb:// URI

tiledb/tests/test_array_from_cloud.py Outdated Show resolved Hide resolved
@kounelisagis
Copy link
Member

We still need TILEDB_TOKEN, TILEDB_NAMESPACE, and S3_BUCKET, so the new test is expected to fail.

@dudoslav dudoslav changed the title Draft: Re-enable automatic upload to pypi Re-enable automatic upload to pypi Oct 2, 2024
@dudoslav dudoslav marked this pull request as ready for review October 2, 2024 13:09
@kounelisagis kounelisagis merged commit a6e1249 into dev Oct 3, 2024
27 checks passed
@kounelisagis kounelisagis deleted the db/pypi_upload_enable branch October 3, 2024 12:42
kounelisagis added a commit that referenced this pull request Oct 23, 2024
@dudoslav @kounelisagis
Re-enable automatic upload to pypi (#2034)
3ee1e25 
* Re-enable automatic upload to pypi
* Add test against tiledb://

---------

Co-authored-by: Agisilaos Kounelis <kounelisagis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihnorton ihnorton ihnorton approved these changes

@kounelisagis kounelisagis Awaiting requested review from kounelisagis

Assignees

@dudoslav dudoslav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dudoslav @kounelisagis @ihnorton