Reflect global context object when creating config #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddelbuettel
requested review from
ihnorton,
aaronwolen,
johnkerl,
awenocur and
mojaveazure
|
This pull request has been linked to Shortcut Story #28496: Correct default configs in consolidate and vacuum calls. |
awenocur
approved these changes
May 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #546
For both consolidation and vacuum, a temporary config was created to set start and end timestamps. That temporary config was a the default which then skips all possible configuration already set in the global context object.
The simple fix to create the
configobject off thectx, either a givem one or the usual global one.